Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE ember-contextual-components] dot-path #12495

Merged
merged 2 commits into from
Oct 19, 2015
Merged

[FEATURE ember-contextual-components] dot-path #12495

merged 2 commits into from
Oct 19, 2015

Conversation

mixonic
Copy link
Sponsor Member

@mixonic mixonic commented Oct 17, 2015

Consider paths with dots in them for rendering as a component. References https://github.com/emberjs/rfcs/blob/master/text/0064-contextual-component-lookup.md

For example via the range hook and redirection:

{{#with (hash profile=(component "user-profile")) as |userComponents|}}
  {{userComponents.profile}}
{{/with}}

And via the inline hook and redirection:

{{#with (hash profile=(component "user-profile")) as |userComponents|}}
  {{userComponents.profile some=attrThing}}
{{/with}}

@rwjblue
Copy link
Member

rwjblue commented Oct 17, 2015

LGTM - 👍

rwjblue added a commit that referenced this pull request Oct 19, 2015
@rwjblue
Merge pull request #12495 from mixonic/dot-path-lookup
c35e15c 
[FEATURE ember-contextual-components] dot-path
@rwjblue rwjblue merged commit c35e15c into emberjs:master Oct 19, 2015
@rwjblue rwjblue deleted the dot-path-lookup branch October 19, 2015 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mixonic @rwjblue